feat(server_conf) update zabbix server formula to v7#175
feat(server_conf) update zabbix server formula to v7#175stevenmallindine wants to merge 1 commit intosaltstack-formulas:masterfrom stevenmallindine:update_zabbix_server_formula_to_v7_master
Conversation
hatifnatt
left a comment
There was a problem hiding this comment.
Thanks for PR!
Are you running with
jinja_env:
trim_blocks: True
lstrip_blocks: Truein the salt -master config?
Otherwise I can't understand why are you removing - (minus sign) from the end of each of {% if ... -%} block. Extra empty lines will be added to configuration files. Please don't introduce changes that will result in big but unnecessary changes in configuration files of each user of this formula.
Long story short - please don't remove minus sign, or please explain why this is necessary.
I would even suggest to add minus sign to the end of the if blocks with new parameters that you added.
|
The removal of the - sign which reintroduces whitespaces was also discussed internally here. I did if to exactly reproduce the same formatting as from Zabbix. |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[feat]A new featureDoes this PR introduce a
BREAKING CHANGE?No.
Describe the changes you're proposing
Update the zabbix server jinja formula to include parameters up to 7.0
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).