feat(osfingermap): updating python git package name for Debian 11 #537
Open
vveliev wants to merge 4 commits intosaltstack-formulas:masterfrom
Open
feat(osfingermap): updating python git package name for Debian 11 #537vveliev wants to merge 4 commits intosaltstack-formulas:masterfrom
vveliev wants to merge 4 commits intosaltstack-formulas:masterfrom
Conversation
baby-gnu
approved these changes
Jan 18, 2023
Comment on lines
+15
to
+25
| Debian-11: | ||
| pygit2: python-pygit2 | ||
| gitfs: | ||
| pygit2: | ||
| install_from_source: true | ||
| version: 1.9.0 | ||
| git: | ||
| require_state: false | ||
| install_from_package: Null | ||
| libgit2: libgit2-glib-1.0-0 | ||
|
|
Contributor
There was a problem hiding this comment.
In case of platform updates, I think that making the new requirement the default and adding configuration for supported older ones is better.
In this case:
- the
osfamillymap.yamlshould use values working for the latest version of the mainstream OS supported by the formula (Debianfor Debian based OS andRedHatfor RedHat based ones) - the
osmap.yamlshould use values working for the latest version of the OS supported by the formula (Ubuntu-22.04for example) - the
osfingermap.yamlshould use values for specific older OS version supported by the formula (Ubuntu-18.04for example)
I remember discussing this topic somewhere with @myii or the @saltstack-formula/wg or even in an issue but can't find the link now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
updating python git package name for Debian 11
When working with gitfs current configuration failing for state
salt.gitfs.pygit2as it's not able to find default package name.Pillar / config required to test the proposed changes
default.
Debug log showing how the proposed changes work
salt-call state.sls salt.gitfs.pygit2Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context