This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Adaptive softmax fixes (#1)#63
Open
amirsaffari wants to merge 1 commit intosalesforce:masterfrom
amirsaffari:master
Open
Adaptive softmax fixes (#1)#63amirsaffari wants to merge 1 commit intosalesforce:masterfrom amirsaffari:master
amirsaffari wants to merge 1 commit intosalesforce:masterfrom
amirsaffari:master
Conversation
amirsaffari
commented
Jul 13, 2018
amirsaffari
commented
- Majority of the code is Python 3 compatible
- Majority of the code runs on CPU if we don't have CUDA command line argument specified and no GPU available
- The pointer and finetune are now compatible with adaptive softmax
- The SplitCrossEntropy now correctly returns logprobs for cases where there are no splits
- ISSUES: finetune still does not work properly, so needs further investigations
* adding Python 3 and other fixes to make pointer and finetune compatible * further fixes to pointer * open now should work in Python2
|
Thanks for the contribution! Before we can merge this, we need @amirsaffari to sign the Salesforce.com Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.