Draft
Conversation
MaxKissgen
reviewed
Apr 11, 2022
Contributor
There was a problem hiding this comment.
I dont think we should do this with a printLn statement and rather use one of our loggers. Otherwise we definitely dont have it in WebOCDs logs for later viewing. Whats your opinion on that?
On another note, I think the Ant algorithm still prints its modularity apart from the final output. I'll double check the other files as well just to be sure
Contributor
Author
|
The point of this was to standardize console output since it differed among algorithms. But yeah, it makes more sense to use a logger and actually do it directly from the Serviceclass when calling the algorithm. I'll change that |
Contributor
Author
|
Issues with logging
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.