Skip to content

Fix contrast ratio for Since element in rustodoc dark theme #151665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arferreira wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix contrast ratio for Since element in rustodoc dark theme #151665

arferreira wants to merge 1 commit into from

Conversation

@arferreira
Copy link

@arferreira arferreira commented Jan 26, 2026 •
edited by GuillaumeGomez
Loading

Changed --right-side-color from #808080 to #ababab in the dark theme.

Screenshot 2026-01-25 at 8 04 29 PM

Verified visually in dark theme, it's now more readable:

Screenshot 2026-01-25 at 8 41 02 PM

Part of #59845
Fixes #151422

@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jan 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

Some changes occurred in GUI tests.

cc @GuillaumeGomez

@rust-log-analyzer

This comment has been minimized.

Sign in to view
GuillaumeGomez
GuillaumeGomez reviewed Jan 26, 2026
View reviewed changes
GuillaumeGomez
GuillaumeGomez reviewed Jan 26, 2026
View reviewed changes
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 26, 2026
Open
11 tasks
@arferreira
Copy link
Author

arferreira commented Jan 26, 2026

@GuillaumeGomez I changed color from #ABABAB to #D0D0D0, now it passed for both specs AA and AAA

#D0D0D0

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jan 26, 2026

Looks good to me, thanks! Please squash your commits then I'll put it into the build queue.

@arferreira arferreira force-pushed the fix-rustdoc-contrast branch from a96e5a9 to c7788af Compare January 26, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rustdoc fails contrast check for a certain element.

4 participants

@arferreira @rustbot @rust-log-analyzer @GuillaumeGomez