-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Bump submodule backtrace
#151659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump submodule backtrace
#151659
Conversation
|
|
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
It is always my preference to have changes in a release but I am happy to acknowledge it is merely a preference. |
|
I think we need to explicitly include a dependency on https://crates.io/crates/windows-link on the appropriate platform. |
Updates git submodule
backtracemainly to include the changes from PR rust-lang/backtrace-rs#746. Note that these changes haven't been released yet, although that shouldn't really matter or do you see it as a requirement?Locally I've confirmed that it fixes #151548. I don't think it warrants a regression test (esp. since backtrace tests are rather fragile aren't they?).
I'm actually not sure if only bumping the version of
rustc-demangleinlibrary/std/Cargo.tomlforbacktracewould've sufficed 😅. I went to great lengths updatingbacktracesince I had to face "package version conflicts" and similar back in PR #150843 when I pointedrustc-demangleandbacktraceto my personal forks. In hindsight though I guess these errors occurred for other reasons.r? workingjubilee (rust-lang/backtrace-rs#746) or reassign