Add find_windows_sdk API
#1663
Merged
Add find_windows_sdk API
#1663
+55
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDenton
force-pushed
the
find-windows-sdk
branch
from
7bb23d5 to
2bd7a51
Compare
This exposes `get_sdks` so that it can be used even if Visual Studio is not installed.
ChrisDenton
force-pushed
the
find-windows-sdk
branch
from
2bd7a51 to
84633b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially exposes
get_sdksso that it can be used even if Visual Studio is not installed.My original motivation was so that rustup can detect which parts of a toolchain install are broken (e.g. MSVC tools are installed but the SDK isn't or vice versa). But I think this can be useful in more general cases too.