Update dependencies to allow building with latest Rust version#31
Update dependencies to allow building with latest Rust version#31cecton merged 11 commits intorust-disk-partition-management:mainfrom
Conversation
cecton
left a comment
There was a problem hiding this comment.
That is awesome thanks a lot! Can you fix the remaining issue? The CI must be green I can't just leave a ❎ like that
| bitvec = "1.0.1" | ||
| bincode = "1.0.1" | ||
| serde = { version = "1.0.116", features = ["derive"] } | ||
| serde-big-array = ">= 0.4.1, < 0.6" |
There was a problem hiding this comment.
I wonder if this shouldn't be upgraded now. Can you check the different versions to see which ones work?
There was a problem hiding this comment.
Why do you think it shouldn't be upgraded?
There was a problem hiding this comment.
No I meant the opposite. Should this be upgraded too, to 0.6 or up idk
There was a problem hiding this comment.
There is no 0.6, 0.5.1 is the latest (https://docs.rs/serde-big-array/latest/serde_big_array/).
|
There we go, clippy warnings fixed |
|
Ah, so that's why. Up to @cecton whether to bump the MSRV or to go back down to a 1.x bincode version, which I assume would work on the latest Rust still. |
Yes I guess since bincode 2 is still just a release candidate, we can't really make a stable release of mbrman like that. Once they finally release it then we can |
|
It seems fine for a stable release, given it's just legacy bincode 1 code, it would just require upping the MSRV to match bincode 2's MSRV |
|
Any update on this? |
|
It looks abandoned. If you want you can make a new PR, fix the CI and I will merge and release. |
|
I never got a decision on whether I should bump the MSRV or go back down to bincode 1.x, unless "yes" meant to downgrade. |
|
oh sorry I remember now I thought it was clear. We can't make a stable release here with a dependency on a release candidate. So using bincode 2 is not acceptable at the moment. But without the upgrade to bincode 2 I assume it won't solve the issue? In that case this PR needs to stay dormant until bincode 2 finally release its stable version. |
|
For anyone who absolutely need this upgrade: you can add a [patch] section in your cargo to use @BigBadE repo and branch with the upgrade. If you find any issue you can report them in this ticket here. |
|
bincode has been released in stable on March 6th 2025. I updated the dependencies and merged |
Rust changing features broke proc, which broke any crates or dependencies using it. This PR simply updates to the latest version of each dependency to fix this issue.
Changes:
I ran all tests, no errors.