Skip to content

fix: restrict transformers version to be less than 4.57.7 #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Azure99 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: restrict transformers version to be less than 4.57.7 #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builder/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ typing-extensions>=4.8.0
pydantic
pydantic-settings
hf-transfer
transformers>=4.57.0
transformers>=4.57.0,<4.57.7
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description frames the problem as pip potentially installing transformers 5.x (incompatible with pinned vllm==0.11.0), but the change pins transformers to <4.57.7, which is much narrower than needed to avoid 5.x and will block newer 4.x patch/minor releases. If the intent is only to prevent 5.x, consider using an upper bound like <5 instead; if 4.57.7+ is specifically known to break with vLLM 0.11.0, please update the PR description (or add a short comment in requirements) to document why that exact cutoff is required.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency transformers>=4.57.0,<4.57.7 in a build/runtime requirements file allows pip to automatically pull new, unreviewed 4.57.x releases within this range, which is a classic software supply-chain attack vector. If an upstream transformers release in this range is compromised, its code will execute in the builder/worker environment with access to any available secrets and the ability to affect builds or runtime behavior. To reduce this risk, pin transformers to a specific, vetted version (and ideally include hashes or vendor it) so that upgrades only occur through explicit review.

Copilot uses AI. Check for mistakes.
bitsandbytes>=0.45.0
kernels
torch==2.6.0
Loading