Skip to content

Conversation

@DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Nov 7, 2025

closes #409

tested locally from fork:

Screenshot 2025-11-07 at 10 37 59

Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 marked this pull request as ready for review November 7, 2025 15:37
@DrFaust92 DrFaust92 requested a review from a team as a code owner November 7, 2025 15:37
@GMartinez-Sisti
Copy link
Member

Seems like we have an issue with unittest -> helm-unittest/helm-unittest#777. Let's follow up for some days and see if it gets solved.

@DrFaust92
Copy link
Contributor Author

GMartinez-Sisti can we pin it to helm 3 meanwhile?

@GMartinez-Sisti
Copy link
Member

GMartinez-Sisti can we pin it to helm 3 meanwhile?

Since the unittest repo is fairly active, I'd rather wait another week or so. This is a nice extra but AFAIK no one is blocked on this.

@DrFaust92
Copy link
Contributor Author

@GMartinez-Sisti seems that many did this https://github.com/FlowFuse/helm/pull/747/files. wdyt?

@GMartinez-Sisti
Copy link
Member

@GMartinez-Sisti seems that many did this https://github.com/FlowFuse/helm/pull/747/files. wdyt?

→ helm plugin install -h | grep -- "--verify"
Use --verify=false to skip signature verification for remote plugins.
      --verify                     verify the plugin signature before installing (default true)

Decreasing the security of the CI tests to provide artifact attestation feels a bit contradictory 😅 Atlantis is an application with the highest level of permissions given its nature. I think it's safer to wait.

We should be able to merge this soon! Thank you for all the help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support GitHub Artifact Attestations

2 participants