Context menu shortcuts and sort dialog#759
Open
bgareth wants to merge 5 commits intoruilisi:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR addresses a number of weaknesses:
Related issue: #758
Changes include:
Keyboard shortcuts for context menus (selection-aware + explicit row/column)**
Cmd/Ctrl + Shift + M-> open context menu for current selection typeCmd/Ctrl + Shift + R-> open row header context menuCmd/Ctrl + Shift + L-> open column header context menuKey files:
Context menu keyboard activation fix
Key file:
Sort modal styling + accessibility fixes
Sort range from G3 to G3now renders with proper spacing.Key files:
Manual Test Checklist
yarn eslinton touched files: passyarn tsc: pass