Refactor of request params parsing process#947
Merged
dblock merged 11 commits intoruby-grape:masterfrom May 24, 2025
Merged
Conversation
numbata
force-pushed
the
request-param-parsers
branch
from
719d29c to
55a94d0
Compare
Contributor
Author
|
Some changes extracted into #948. |
numbata
force-pushed
the
request-param-parsers
branch
from
a99e07a to
011800a
Compare
numbata
force-pushed
the
request-param-parsers
branch
from
157b1dd to
bffbbd4
Compare
Member
|
Rebase the conditional |
numbata
force-pushed
the
request-param-parsers
branch
from
bffbbd4 to
8591b5d
Compare
numbata
force-pushed
the
request-param-parsers
branch
from
8591b5d to
15331a0
Compare
numbata
force-pushed
the
request-param-parsers
branch
from
15331a0 to
513d35b
Compare
dblock
approved these changes
May 24, 2025
numbata
added a commit
to numbata/grape-swagger
that referenced
this pull request
Dec 6, 2025
* wip * Form params parser. First step * Cleanup mess a bit * Fix specs * Let rubocop be happy * Fixes after rubocop autocorrection * Cleanup a little * Fix spec * Add requst param parser regestry * Refactor param parsers * Fix rubocop offenses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request splits the request parameter handling into separate parser classes for headers, routes, and bodies. This means the code is more organized and easier to work with, making life easier for contributors and maintainers. It's a step toward adding new features-like contract-based parameter parsing-without having to tangle everything up in one place.
By separating concerns, developers can more easily customize or extend the way parameters are handled. In the future, we will be able to add stricter validation or additional checks simply by creating or updating a parser class. Overall, these changes should keep things cleaner, pave the way for stronger parameter validation, and help the project evolve smoothly.
In two words: my main goal here is to be able to add contract-based request params parser as one of the next steps.