Fix version parsing when bundler outputs diagnostic messages#44
Open
JoeSouthan wants to merge 1 commit intorubocop:masterfrom
Open
Fix version parsing when bundler outputs diagnostic messages#44JoeSouthan wants to merge 1 commit intorubocop:masterfrom
JoeSouthan wants to merge 1 commit intorubocop:masterfrom
Conversation
When running `bundle exec rubocop -v`, bundler may output diagnostic messages like "Resolving dependencies" to stdout before the actual RuboCop version number. This caused version detection to fail since the entire stdout was being treated as the version string. Now we extract only the last line of the output, which contains the actual RuboCop version, while ignoring any bundler messages that appear before it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
bundle exec rubocop -v, bundler may output diagnostic messages like "Resolving dependencies" to stdout before the actual RuboCop version number. This caused version detection to fail since the entire stdout was being treated as the version string.Now we extract only the last line of the output, which contains the actual RuboCop version, while ignoring any bundler messages that appear before it.