Fix unification variables not persisting in any-order nodes#399
Merged
Fix unification variables not persisting in any-order nodes#399
Conversation
marcandre
force-pushed
the
unification-fix
branch
2 times, most recently
from
22c47d0 to
34682ce
Compare
Unification variables inside any-order patterns (`<>`) were not working
correctly due to Ruby's block scoping behavior. The pattern
`(or <(send _receiver :bar) (send _receiver :baz)>)` would match
`foo.baz || foo.bar` but fail to match `foo.bar || foo.baz`.
```ruby
# Current (bad):
(matched = {}; true) &&
(2).times do
when ... && (unify_receiver = value; true) ... # Inside block - doesn't persist!
end
# Good:
(matched = {}; unify_receiver = nil; true) && # Initialize outside!
(2).times do
when ... && (unify_receiver = value; true) ... # Now assigns to existing variable
end
```
[Fixes #335]
marcandre
force-pushed
the
unification-fix
branch
from
34682ce to
1b9231d
Compare
Contributor
Author
|
Released as 1.49.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unification variables inside any-order patterns (
<>) were not working correctly due to Ruby's block scoping behavior. The pattern(or <(send _receiver :bar) (send _receiver :baz)>)would matchfoo.baz || foo.barbut fail to matchfoo.bar || foo.baz.[Fixes #335]