Separate the localizable UI strings from the plugin name #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tested upto to 5.7
See WordPress.org SVN lint error:
svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:
PHP error in: login-with-google/tags/1.0.11/vendor/symfony/polyfill-intl-idn/bootstrap80.php:
Parse error: syntax error, unexpected '|', expecting '{' in Standard input code on line 124
Errors parsing Standard input code
Ensure that the passed state is received. Also, check for provider to ensure that google plugin needs to handle returned response
[Fix] Verify state on round trip
[Bug-Fix] Compare expected state with received state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't translate the plugin name so keep it as English but some extra same and localizable UI strings can't be separated from the plugin name.
The modified codes can reach this purpose.