Skip to content

add missing wikipage in test#713

Merged
matsl merged 4 commits intomasterfrom
add-missing-wikipage-in-test
Apr 26, 2025
Merged

add missing wikipage in test#713
matsl merged 4 commits intomasterfrom
add-missing-wikipage-in-test

Conversation

@matsl
Copy link
Copy Markdown
Collaborator

@matsl matsl commented Apr 24, 2025

What

  • Add missing WikiPage required for successful test
  • Refactor: Reuse hywiki-word-face-at-p
  • Add skip-unless guard for face test

Why

The good news: The with face test was failing due to that the WikiPage
Hiho was not created. So now plain textual WikiWord verification works
as well when the overlay face is checked.

The bad news: The test of course needs to be run interactively only to
work.

The even odder and possibly worse news: I have a simple test, that
when I run manually in my Emacs fails, but works in the CI or if I run
it in dockerized Emacs!? The test recipe is simple:

  1. Enter a WikiWord (WikiWord is highlighted)
  2. Add a space after (WikiWord is still highlighted)
  3. Remove the space (WikiWord is still highlighted)
  4. Add space again after. WikiWord is not highlighted.

@matsl matsl requested a review from rswgnu April 24, 2025 16:40
@matsl matsl force-pushed the add-missing-wikipage-in-test branch from 79ae387 to 7f5bb29 Compare April 26, 2025 08:40
@matsl
Copy link
Copy Markdown
Collaborator Author

matsl commented Apr 26, 2025

@rswgnu PTAL The PR should be good to go in.

@matsl matsl merged commit 2648dd8 into master Apr 26, 2025
4 checks passed
@matsl matsl deleted the add-missing-wikipage-in-test branch April 26, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants