Add face verification for hywiki--word-face#711
Merged
Conversation
Make a copy of the step check that does the same verification but adds a check of the face of the matching WikiWord.
rswgnu
approved these changes
Apr 24, 2025
Owner
rswgnu
left a comment
rswgnu
left a comment
There was a problem hiding this comment.
Fix the one typo noted in the review and then approved.
| (cl-return t)))) | ||
|
|
||
| (defun hy-test-word-face-at-region (beg end) | ||
| "Non-nil if all chars in region [BEG, END] has `hywiki--word-face'." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add face verification for hywiki--word-face.
Make a copy of the step check that does the same verification but adds
a check of the face of the matching WikiWord.
Why
WikiWords should not only be recognized as text but should also have
the right face for visual feedback to the user.
This combines the check of the text with a check that an overlay
exists with the right face.
Note
The test does fails due to the face check. Is it thus put behind the
failure flag to not be executed in the CI.