Fix encKey threshold for RTW command calculation#650
Open
macphisto82 wants to merge 1 commit intorstrouse:mainfrom
Open
Fix encKey threshold for RTW command calculation#650macphisto82 wants to merge 1 commit intorstrouse:mainfrom
macphisto82 wants to merge 1 commit intorstrouse:mainfrom
Conversation
|
I will send you my compiled files. This will need some time as I tried to use newer libraries later on. So I have to figure out where they are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here #514
this commit fixes RTW protocol frame decoding, now commands from physical remotes displayed in the logs match the actual commands, and shade position is correct.
tested on my personal ASA motor
thanks to @VolkerMer