Open
Conversation
…ip hist beyond these values
JoOkuma
requested changes
Mar 13, 2025
Member
JoOkuma
left a comment
There was a problem hiding this comment.
Thanks for the PR @dsundarraman, I left a few minor comments
Co-authored-by: Jordão Bragantini <jordao.bragantini@czbiohub.org>
Co-authored-by: Jordão Bragantini <jordao.bragantini@czbiohub.org>
JoOkuma
requested changes
May 8, 2025
Member
JoOkuma
left a comment
There was a problem hiding this comment.
Hi @ilan-theodoro, thank you for the fix.
I would suggest using the dispatch mechanism from numpy and avoiding importing the libraries as xp unless it's really necessary.
https://github.com/royerlab/dexpv2/blob/main/dexpv2/crosscorr.py is a good example of how most functions are implemented in dexpv2.
I understand that this is a cupy only fix, so it might be worth adding a function is_cupy_array to dexpv2.cuda, and even replacing this section of the code
Lines 137 to 138 in d13e1e0
This would simplify the typing.
It might be useful the fact that, np.float16 == cp.float16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified fancy threshold function to incorporate max foreground to clip hist beyond these values. Default value 0.0 not ideal but should work for the application.