fix(github): support auto/system theme mode #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure selectors to properly match GitHub's auto theme mode by: - Moving media queries outside parent selectors for correct specificity - Adding explicit html element to attribute selectors - Adding !important to accent-color variables to override GitHub defaults Bump version to 1.1.1.
- Add tooltip colors matching rose-pine palette - Make disabled buttons readable with solid backgrounds and muted text - Use @muted for disabled foreground colors instead of faded/transparent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GitHub auto/system theme mode
Problem
The userstyle doesn't work properly when GitHub is set to "System" theme mode. CSS variables get overridden by GitHub's defaults.
Solution
!importantto theme variables that were getting overriddenTesting
With "system/auto" theme
Before
After
Disabled enterprise buttons
Before
After