fix non standard interface locations. (#1186)#1205
Open
techtasie wants to merge 1 commit intoros2:kiltedfrom
Open
fix non standard interface locations. (#1186)#1205techtasie wants to merge 1 commit intoros2:kiltedfrom
techtasie wants to merge 1 commit intoros2:kiltedfrom
Conversation
Signed-off-by: Tim Wendt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of relying on the broken
get_interface_pathfunction, I use therosidl_interfacesresource directly. (see explanation)Fixes #1186
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
For rolling, this issue will be resolved by changing the behavior of ros2idl in ros2/rosidl#935
This patch can be backported to Jazzy and humble.
I am unsure whether it is correct to fix this in ros2cli or whether the change should happen in
rosidl_runtime_py. Due to the huge number of packages that depend onrosidl_runtime_py, I am hesitant to make that change there, especially since packages rarely rely on the.msg/.srv/.actionfiles.