#524 JumpTimeCallbacks#629
Draft
balthasarschuess wants to merge 2 commits intoros2-rust:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my draft for the time jump callbacks feature.
#524
The way it works right now is:
TODO:
clock.sleep_forclock.sleep_until+ use_simulation_timeRegarding the
/clocksubscription withuse_sim_timein thetime_sourcemodule:I was also wondering if we should even schedule clock change callbacks in the executor.
As I am unsure whether the WaitSet/WaitSetRunner has stable message ordering / guarantees, that we won't process an old message, after the clock time changed.
It would be awkward to spin subscription messages from the earlier simulation time, after state was cleared on time jump.