fix: do not run logging tests in parallel#626
Open
esteve wants to merge 1 commit intoros2-rust:mainfrom
Open
Conversation
Signed-off-by: Esteve Fernandez <[email protected]>
Collaborator
Author
|
Perhaps a more complete approach would be to protect such global state inside r |
Collaborator
Author
|
The issues with the rolling job are caused by |
Collaborator
Author
|
Here's an example of a failing CI job crashing: https://github.com/ros2-rust/ros2_rust/actions/runs/24464336823/job/71487081210?pr=625 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the logging tests run sequentially. Logging in ROS is not thread-safe as it uses global state, when
cargo testruns these tests in parallel, sometimes cargo crashes with a SIGSEGV.