Skip to content

fix: do not run logging tests in parallel#626

Open
esteve wants to merge 1 commit intoros2-rust:mainfrom
esteve:fix-logging-crash
Open

fix: do not run logging tests in parallel#626
esteve wants to merge 1 commit intoros2-rust:mainfrom
esteve:fix-logging-crash

Conversation

@esteve
Copy link
Copy Markdown
Collaborator

@esteve esteve commented Apr 15, 2026

This PR makes the logging tests run sequentially. Logging in ROS is not thread-safe as it uses global state, when cargo test runs these tests in parallel, sometimes cargo crashes with a SIGSEGV.

@esteve esteve requested review from maspe36 and mxgrey April 15, 2026 15:50
@esteve
Copy link
Copy Markdown
Collaborator Author

esteve commented Apr 15, 2026

Perhaps a more complete approach would be to protect such global state inside rclrs, but these changes should suffice.

@esteve
Copy link
Copy Markdown
Collaborator Author

esteve commented Apr 15, 2026

The issues with the rolling job are caused by action-ros-ci, I think the APT repos are not updated with the latest rolling sync.

@esteve
Copy link
Copy Markdown
Collaborator Author

esteve commented Apr 15, 2026

Here's an example of a failing CI job crashing:

https://github.com/ros2-rust/ros2_rust/actions/runs/24464336823/job/71487081210?pr=625

error: test failed, to rerun pass `-p rclrs --lib`
  
  Caused by:
    process didn't exit successfully: `/__w/ros2_rust/ros2_rust/ros_ws/build/rclrs/debug/deps/rclrs-051c2c557ee4ff13 --color=never --quiet` (signal: 11, SIGSEGV: invalid memory reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant