Closed
Conversation
Author
|
Looks like there is another PR doing the same: #592. Please, ignore this one. |
Collaborator
Author
|
Hey @esteve, I tried to adopt the code from #592. It doesn't work in my environment. I need more time to investigate why. It may be the way I've integrated it. However, I can see that my patch adheres to the project API style and uses callbacks. I've already tested it in a production environment, processing thousands of messages per second with no issues. Would you prefer to use my work? In any case, I'm open to collaborating on both approaches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're developing a bridge that will receive and store serialised data in its original form in a database. This patch enables that functionality. I didn't put much effort into it as it's generated code. However, if the team sees value in this feature, I can develop it further.
Thank you for the awesome library!