update CI with jazzy and noble#490
Conversation
|
Considering we're trying to have this client library be a Tier 1, I think we should support Humble (and other versions) for as long as ROS 2 supports them. So if a version becomes EOL, our support becomes EOL. I am open to being overruled by the other maintainers if they feel that would be an unrealistic ask, though. |
|
Alright. In that sense I can also add Kilted. Iron is of course already EOL. Once the PR is ready to be reviewed I'll share it on Matrix |
|
I've removed Kilted again since it is not yet available in rostooling it seems: https://github.com/ros-tooling/setup-ros-docker I'll start a issue/pr over there, but for now I've commented it out here |
luca-della-vedova
left a comment
luca-della-vedova
left a comment
There was a problem hiding this comment.
Had a quick look upstream and it seems kilted is now available, can you uncomment it?
|
Absolutely :) the rostooling peeps were really quick to respond after opening my ticket for kilted there! PR merged in record time! |
|
ah no it's too fresh. We need to wait for the new action-ros-ci (and setup-ros?) to be released with kilted. It's either that or always be on the @main version of those but don't think we should do that to keep the CI stable. So, shall we wait for that for this PR or shall I remove Kilted again such that we can do another PR once the tooling has been released @luca-della-vedova ? |
It seems both have kilted support, |
luca-della-vedova
left a comment
luca-della-vedova
left a comment
There was a problem hiding this comment.
Just a comment for curiosity but this looks great, thank you! This (especially jazzy) is very overdue
| # Colcon can not be run in a venv which is required in Ubuntu Noble | ||
| # Removing the externally managed file | ||
| - name: Install colcon-cargo and colcon-ros-cargo | ||
| run: | | ||
| sudo rm -f /usr/lib/python3.12/EXTERNALLY-MANAGED |
There was a problem hiding this comment.
Very interesting, I guess this is an alternative to the --break-system-packages flag? I didn't know this could be done!
There was a problem hiding this comment.
ah yes I read about that flag too. But I got this idea from my co-maintainer at Crazyswarm2 (see this line). But seems to work out!
|
Everything is building so feel free to merge if it's all good! |
jhdcs
left a comment
jhdcs
left a comment
There was a problem hiding this comment.
These changes appear good to me. Going to see if I can re-run the CI...
|
All checks have passed. Merging. |
3 participants
An update to the CI
Do we want to keep supporting humble? and how about short term releases as iron and kilted
Update: I still have to update the minimal build and see if everything goes through error free, hence the that this PR is still on draft. Also there is #489 that will fix the windows build