Skip to content

Add missing tests for pendulum and gripper (position and effort) (backport #814)#823

Draft
mergify[bot] wants to merge 1 commit intokiltedfrom
mergify/bp/kilted/pr-814
Draft

Add missing tests for pendulum and gripper (position and effort) (backport #814)#823
mergify[bot] wants to merge 1 commit intokiltedfrom
mergify/bp/kilted/pr-814

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Mar 28, 2026

This PR adds several missing integration tests for the demos in gz_ros2_control_demos.

Included:

  • pendulum position test
  • gripper position test
  • gripper effort test

These tests follow the same structure as the precedent tests:

  • verify /joint_states is published
  • verify controllers are loaded and active
  • check initial joint state when applicable
  • launch the example node and ensure it exits cleanly

Additional fixes:

  • corrected launch files to accept gz_args
  • updated pendulum position URDF to match the expected initial state
  • updated CMakeLists to install and register the new tests

Mobile robot tests (diff_drive, mecanum, ackermann, tricycle) will be added in a separate PR, since they have no initial_value and require a slightly different test structure.


This is an automatic backport of pull request #814 done by Mergify.

@mergify mergify Bot requested a review from ahcorde as a code owner March 28, 2026 18:21
@mergify mergify Bot added the conflicts label Mar 28, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Mar 28, 2026

Cherry-pick of 21643f3 has failed:

On branch mergify/bp/kilted/pr-814
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit 21643f3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   gz_ros2_control_demos/launch/gripper_mimic_joint_example_effort.launch.py
	modified:   gz_ros2_control_demos/launch/gripper_mimic_joint_example_position.launch.py
	modified:   gz_ros2_control_demos/launch/pendulum_example_position.launch.py
	modified:   gz_ros2_control_demos/urdf/test_pendulum_position.xacro.urdf
	new file:   gz_ros2_control_tests/tests/gripper_mimic_joint_effort_test.py
	new file:   gz_ros2_control_tests/tests/gripper_mimic_joint_position_test.py
	new file:   gz_ros2_control_tests/tests/pendulum_position_test.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   gz_ros2_control_tests/tests/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich
Copy link
Copy Markdown
Member

christophfroehlich commented Mar 28, 2026

Waiting for #830

@christophfroehlich christophfroehlich force-pushed the mergify/bp/kilted/pr-814 branch from 56352b9 to 867d8f0 Compare April 13, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants