Add initial_value checks to state interface tests (backport #765)#774
Open
mergify[bot] wants to merge 1 commit intohumblefrom
Open
Add initial_value checks to state interface tests (backport #765)#774mergify[bot] wants to merge 1 commit intohumblefrom
mergify[bot] wants to merge 1 commit intohumblefrom
Conversation
Contributor
Author
|
Cherry-pick of 5c63578 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
f19eb02 to
ab0b331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test to verify that the
slider_to_cartjoint is present in/joint_statesbefore the velocity example starts moving the robot.This addresses the part of issue #764 related to checking initial_value
availability before motion. The test does not assert the numeric value of the
initial position, since
/joint_statesmay publish an uninitialized value inthe first cycles of simulation. Instead, it ensures that the joint is present
and published before the controller starts sending commands.
All tests pass locally, including flake8.
This is an automatic backport of pull request #765 done by [Mergify](https://mergify.com).