Cleanup code and use composable nodes for Gazebo#511
Cleanup code and use composable nodes for Gazebo#511Amronos wants to merge 16 commits intoros-controls:rollingfrom
Conversation
christophfroehlich
left a comment
There was a problem hiding this comment.
I'm not familiar with the composable nodes of gazebo. How does #375 (comment) apply then? If we advertise this here, should we fix what is mentioned there before?
Co-authored-by: Christoph Fröhlich <[email protected]>
TBH, I am not really sure about that. From my testing passing parameters through URDF/SDF works just fine when using composable nodes (there was #441 which was fixed with #442). |
christophfroehlich
left a comment
There was a problem hiding this comment.
The example_mobile_robots part is fine, can you please split this up in separate PRs?
About os.path.join see the conversation there.
Will do. |
|
Shifted the cmd_vel unification to #530. |
|
Shifted the addition of odometry plugin to #531. |
ahcorde
left a comment
There was a problem hiding this comment.
do you mind to fix conflicts ?
I have currently made these changes only for thediff_drive_controllerdemo and will propagate them to the other demos if they look good.Demos completed: