Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ros2-master #238 +/- ##
============================================
Coverage 78.38% 78.38%
============================================
Files 30 30
Lines 1888 1888
Branches 114 114
============================================
Hits 1480 1480
Misses 338 338
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
Contributor
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
68188cf to
6148bf9
Compare
84a4531 to
3ffa9c7
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
(cherry picked from commit b2b3425)
1 task
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
(cherry picked from commit b2b3425)
1 task
christophfroehlich
pushed a commit
that referenced
this pull request
Jun 23, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs ros-controls/ros2_control_ci#374
I had to make a workaround for RSL, because colcon+MSVC does not consider the CMakePresets file.
Needs upstream changes: