Conversation
|
|
||
| cm_path <- check_pkg_version_path () | ||
|
|
||
| # Code from list-packages.R to get all pkgs: |
There was a problem hiding this comment.
why not use packages.json?
| other_packages <- get_other_packages() | ||
| packages <- c(hosted_packages, other_packages) | ||
| packages <- packages[order(purrr::map_chr(packages, "package"))] | ||
| packages <- lapply (packages, function (i) i [c ("package", "url", "branch")]) |
There was a problem hiding this comment.
why not purrr? since it' used on the line above
There was a problem hiding this comment.
Yeah, no reason really, purrr throughout would be better
| dat <- gh::gh_gql (query = q) | ||
| page_info <- dat$data$repositoryOwner$repositories$pageInfo | ||
| repo_data <- dat$data$repositoryOwner$repositories$nodes | ||
| while (page_info$hasNextPage) { |
There was a problem hiding this comment.
why get all releases and not just the latest one that's not a draft? https://github.com/ropensci/roweb3/blob/e4042ee863c9e0992ff3d34b1d81b9c9792b176d/archetypes/newsletter/index.md?plain=1#L228
There was a problem hiding this comment.
and why use the V4 API for this?
There was a problem hiding this comment.
All releases because at least initially we need all that information that we currently don't have. And v4 API because we can grab the whole org in one call; with the REST api, we'd have to do each repo as a separate call.
2 participants
No description provided.