Skip to content

Mention ClassDefOverride#1118

Closed
ferdymercury wants to merge 3 commits intoroot-project:mainfrom
ferdymercury:patch-3
Closed

Mention ClassDefOverride#1118
ferdymercury wants to merge 3 commits intoroot-project:mainfrom
ferdymercury:patch-3

Conversation

@ferdymercury
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread manual/io_custom_classes/index.md Outdated
@ferdymercury
Copy link
Copy Markdown
Contributor Author

This is related to root-project/root#18918 (comment)

@ferdymercury ferdymercury requested a review from pcanal June 11, 2025 21:42
@silverweed
Copy link
Copy Markdown
Contributor

Can/should this be merged?

@ferdymercury
Copy link
Copy Markdown
Contributor Author

Yes please :)

@silverweed
Copy link
Copy Markdown
Contributor

@ferdymercury I think the CI is failing due to missing credentials. This is expected if you opened this PR from a fork (see here): if that's the case, could you please reopen it by branching the main repo instead? I'll approve it and we can merge it once the CI passes

@ferdymercury
Copy link
Copy Markdown
Contributor Author

@ferdymercury I think the CI is failing due to missing credentials. This is expected if you opened this PR from a fork (see here): if that's the case, could you please reopen it by branching the main repo instead? I'll approve it and we can merge it once the CI passes

Hi @silverweed, I no longer have rights to open a branch in the web-repo directly, that's why I went through the fork.

@silverweed
Copy link
Copy Markdown
Contributor

Ah, I see, then I guess I'll do it.
Thanks for the contribution!

@ferdymercury ferdymercury deleted the patch-3 branch July 8, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants