Improve tests and documentation of the Shopping API. (V 2.0) #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally improved documentation of one (the most important) call of ``ebay.finding``.
Test was also made more portable and more robust. Polishing test_shopping.py.
Conflicts: ebay/config.ini.example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second attempt. I fixed one more typo, and also merged the differences between the repositories.
tests/test_shopping.py) now work, and actually test something.ebay/shopping.py) has now relatively extensive docstrings.ebay/finding.py) has now documentation too, but documenting all functions is too much work for now.tests/test_shopping.py,tests/test_finding.py,tests/test_alternative_config, now use an alternative configuration file.I'll merge the changes in a week or so, if no one objects.