Revert "fix safeAreaInsets for iOS 11"#53
Open
d4rkd3v1l wants to merge 1 commit intoromansorochak:masterfrom
Open
Revert "fix safeAreaInsets for iOS 11"#53d4rkd3v1l wants to merge 1 commit intoromansorochak:masterfrom
d4rkd3v1l wants to merge 1 commit intoromansorochak:masterfrom
Conversation
This reverts commit 77814dc. We're using the parallax header on the very top of one of our screens. This change leads to a top offset (44pt) on newer "notch devices" as we don't want to constraint to the safeArea but, to the very top of the screen.
tukestolo
approved these changes
May 4, 2020
Author
|
I really like to switch back to the main repo for my projects. Can we expect this to be merged any time soon? 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 77814dc.
We're using the parallax header on the very top of one of our screens. This change leads to a top offset (44pt) on newer "notch devices" as we don't want to constraint to the safeArea but, to the very top of the screen.