Compile without (u)int64 and with 16-bit (u)int, solving rokath/trice#607 and rokath/trice#608#609
Merged
rokath merged 6 commits intorokath:mainfrom Mar 19, 2026
Merged
Compile without (u)int64 and with 16-bit (u)int, solving rokath/trice#607 and rokath/trice#608#609rokath merged 6 commits intorokath:mainfrom
rokath merged 6 commits intorokath:mainfrom
Conversation
…h 16 bit integer width (rokath#608).
…h 16 bit integer width (rokath#608).
Contributor
Author
|
Regarding the automated checks:
|
Owner
|
Hello THQ-WIFA, thank you very much for your contribution — I really appreciate the effort you put into this. Before I can merge it, could you please revert the changes from Additionally, I would suggest the following adjustments instead:
I believe this approach keeps the intent clearer and maintains consistency. No need to worry about the link check or formatting issues for now. Thanks again for your contribution! |
Contributor
Author
|
Hello @rokath, I have implemented the change in THQ-WIFA/trice@7e3e9a2, mostly as proposed:
I have tested that with TRICE_CYCLE_COUNTER == 1, and I have received >256 trices without issues. |
This was referenced Mar 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #607 and #608.
Note that I have not been able to do tests on other compilers: