Support for PumpMessageLoop, needed for webassembly#355
Open
fizx wants to merge 5 commits intorogchap:masterfrom
Open
Support for PumpMessageLoop, needed for webassembly#355fizx wants to merge 5 commits intorogchap:masterfrom
fizx wants to merge 5 commits intorogchap:masterfrom
Conversation
fizx
changed the title
fizx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on (extends) #356's []byte support.
I haven't figured out a nice way to polyfill this into WebAssembly.compile yet, but this at least allows you to PumpMessageLoop at all. WebAssembly.compile uses both background and foreground tasks, and if you don't pump the message loop, the foreground tasks never execute, leading to a hanging process.
See the test case for how to do this. I'm following the idea of make it possible first, then make it nice later.