This repository was archived by the owner on Mar 11, 2018. It is now read-only.
Issue #24 fix character classes #25
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24. Apart from including the missing characters (
z,Z, and9) in their respective classes and filters, this change should yield equal results as the upstream version.I didn't want to change the functionality drastically not to break existing code, but this trait is actually reinventing the character classes already available on Scala's
Charclass. These includeisLower,isUpper,toLower,isLetter,isDigit`, etc.I would suggest deprecating this trait and use the following existing alternatives (compatible with the
StringTransformtype):_.filter(_.isLetter)instead offilterAlpha_.filterNot(_.isLetter)instead offilterNotAlpha_.filter(_.isDigit)instead offilterNumeric_.filterNot(_.isDigit)instead offilterNotNumeric_.filter(_.isLetterOrDigit)instead offilterAlphaNumeric_.filterNot(_.isLetterOrDigit)instead offilterNotAlphaNumeric_.filter(_.isLower)instead offilterLowerCase_.filterNot(_.isLower)instead offilterNotLowerCase_.filter(_.isUpper)instead offilterUpperCase_.filterNot(_.isUpper)instead offilterNotUpperCase_.map(_.toLower)instead ofignoreAlphaCaseThey are not equivalent, but they are part of the standard library, and I would argue that they are much more accurate than the existing filters.