Use separate exports for ES and CommonJS modules#30
Open
rejc2 wants to merge 67 commits intorochars:masterfrom
Open
Use separate exports for ES and CommonJS modules#30rejc2 wants to merge 67 commits intorochars:masterfrom
rejc2 wants to merge 67 commits intorochars:masterfrom
Conversation
Add cart chunk support
Fix mext soundinfo math
Remove nontechnical information.
Allow smpl chunk to be read via CLI
Structure and annotate, add and fix links
a3d3839 to
fd962d8
Compare
Use separate exports for ES and CommonJS modules
Add Typescript types for fmt and data chunks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the approach recommended in the Node.js documentation:
https://nodejs.org/api/packages.html#approach-1-use-an-es-module-wrapper
Reason for change
Currently if you import the
'wavefile'package from an ES module in Node, Node will use the CommonJS module indist/wavefile.jsand treat the object exported there as the default export.This means that in order to get the
WaveFileclass, you will need to do:rather than the expected pattern of:
The change in this PR re-exports
WaveFilein a ESM wrapper module.