feat(engine): replace TinkerBackendServer with in-process local handler#448
Merged
jeffreysijuntan merged 1 commit intorllm-org:mainfrom Mar 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the integration or Tinker with rllm-model-gateway by replacing the TinkerBackendServer (a standalone http server) with a simple local handler; also adds tool call support.
Type of change
What changed
tests/conftest.pyto try importing first so that integration can run when the dependencies are available.Validation
pre-commit run --all-filespytest ...Validation details:
pytest tests/engine/test_trace_converter.pypytest tests/integration/test_tinker_gateway_integration.py(TINKER_API_KEYenv var required).Breaking changes / migration notes
Docs / examples
Related issues / PRs
Screenshots / logs