fix(metrics): include dropped workflow episodes in denominators#442
Merged
jeffreysijuntan merged 1 commit intorllm-org:mainfrom Mar 16, 2026
Conversation
Workflow episodes that terminate before producing any steps were previously dropped (repeat_counts=0) and excluded from termination and pass@k metrics, inflating accuracy and hiding max_prompt_length_exceeded. Track dropped episodes in meta_info and include them in trainer metrics. Fixes rllm-org#382.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #382 reports that workflow episodes that terminate before producing any steps (e.g. max_prompt_length_exceeded) are silently dropped (repeat_counts=0) and not counted in metrics, inflating pass@k and hiding termination reasons.
This PR:
AgentWorkflowEngine.transform_results_for_verland returns them inmeta_info.dropped_episodes.AgentWorkflowTrainerto:termination_countsnum_tasksas denominator for termination metricsFixes #382