Fixed bug where m_initCount was set to 0 after initialization#786
Open
ITR13 wants to merge 1 commit intorlabrecque:masterfrom
Open
Fixed bug where m_initCount was set to 0 after initialization#786ITR13 wants to merge 1 commit intorlabrecque:masterfrom
ITR13 wants to merge 1 commit intorlabrecque:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just encountered a bug where I was calling SteamAPI.Init() in RuntimeInitializeLoadType.AfterAssembliesLoaded, and InitOnPlayMode ended up overwriting the m_initCount value, despite it being in a build and me not having domain reload on.
This PR essentially just ensures it only tries to do it in editor, and I added some code to ensure it only happens if the developer has DisableDomainReload enabled, since that's the purpose that was listed in the comment.