util: Extend string search with user-defined printable characters#5998
Open
cheese-cakee wants to merge 4 commits intorizinorg:devfrom
Open
util: Extend string search with user-defined printable characters#5998cheese-cakee wants to merge 4 commits intorizinorg:devfrom
cheese-cakee wants to merge 4 commits intorizinorg:devfrom
Conversation
Add str.unprintable config option to define code points treated as non-printable during string search and display. Add grapheme_length field to RzDetectedString for visual character count. * Add rz_unicode_code_point_is_printable_user() for user overrides * Add str.unprintable config option (comma-separated hex code points) * Add grapheme_length to RzDetectedString for visual character count * Add unit tests for user-defined unprintable and grapheme counting * Wire user_unprintable through RzUtilStrScanOptions and RzStrStringifyOpt All unit tests pass
cheese-cakee
requested review from
Rot127,
kazarmy,
ret2libc,
thestr4ng3r and
wargio
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
cheese-cakee
added a commit
to cheese-cakee/rizin
that referenced
this pull request
Mar 6, 2026
The RzSearchOpt and RzBuffer instances were not freed at the end of test cases, which caused an LSan test failure in CI. Fixes rizinorg#5998 Co-Authored-By: Claude <[email protected]>
The RzSearchOpt and RzBuffer instances were not freed at the end of test cases, which caused an LSan test failure in CI. Fixes rizinorg#5998
cheese-cakee
force-pushed
the
extend-string-search
branch
from
128502d to
2accda4
Compare
Rot127
requested changes
Mar 7, 2026
Member
Rot127
left a comment
Rot127
left a comment
There was a problem hiding this comment.
It needs some regression tests in test/db/.... Please add some, with multiple characters, autf-8 chars, only a single one etc.
| if (node->value[0] == '?') { | ||
| rz_cons_printf("Comma-separated list of Unicode code points treated as non-printable.\n"); | ||
| rz_cons_printf("Examples:\n"); | ||
| rz_cons_printf(" e str.unprintable=0x09,0x0a,0x0d,0x1b\n"); |
Member
There was a problem hiding this comment.
Add an example with an UTF-8 character please. E.g. a formatting character.
Also a test.
| ut64 addr; ///< Address/offset of the string in the RzBuffer | ||
| ut32 size; ///< Size of buffer containing the string in bytes | ||
| ut32 length; ///< Length of string in chars | ||
| ut32 grapheme_length; ///< Length of string in grapheme clusters |
Member
There was a problem hiding this comment.
Don't introduce graphemes. It is too complex. People should only define code points, that's it.
Member
|
Also, why did you remove the AI disclaimer of yours? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Description
Closes #4930
Extend string search to support:
User-defined non-printable characters via a new
str.unprintableconfig option (comma-separated hex code points). This adds a newrz_unicode_code_point_is_printable_user()function that checks user overrides before falling back to the standard printability check.Grapheme cluster counting in search hits via a new
grapheme_lengthfield inRzDetectedString. This counts visual characters (base + combining marks) rather than raw code points.Changes made
rz_unicode_code_point_is_printable_user()inlibrz/util/unicode.cstr.unprintableconfig option inlibrz/core/cconfig.cuser_unprintable/user_unprintable_counttoRzUtilStrScanOptionsandRzStrStringifyOptgrapheme_lengthtoRzDetectedStringcount_graphemes()helper instr_search.cRzUtilStrScanOptionsTesting
All existing and new unit tests pass: