This repository was archived by the owner on Sep 2, 2025. It is now read-only.
Open
Conversation
According to https://docs.rs/embedded-hal/latest/embedded_hal/digital/v2/trait.StatefulOutputPin.html, the functions in StatefulOutputPin should not read the actual electrical value of the pin, but the current state of the output driver. The fe310 manual states: "Reading the output_val register returns the written value. Reading the input_val register returns the actual value of the pin gated by input_en." So the right thing to do here is to read the corresponding bit in the output register.
Collaborator
Sadly currently neither do I since I burned my redv :( |
|
I tested this on my RED-V, works fine 👍 . An aside: I was wondering, whether if in the output functions ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://docs.rs/embedded-hal/latest/embedded_hal/digital/v2/trait.StatefulOutputPin.html,
the functions in StatefulOutputPin should not read the actual electrical
value of the pin, but the current state of the output driver.
The fe310 manual states: "Reading the output_val register returns the
written value. Reading the input_val register returns the actual value
of the pin gated by input_en."
So the right thing to do here is to read the corresponding bit in the
output register.
NOTE: I don't have hardware to actually test this fix.