Open
Conversation
This commit fixes the critical issue where the commit-msg hook was not tracked in the repository, preventing new contributors from installing the hook. Changes: - Add scripts/commit-msg as a tracked file containing the hook - Update installation script to copy from scripts/commit-msg to .git/hooks/ - Update CONTRIBUTING.md manual installation instructions to reference the correct source location (scripts/commit-msg) The hook enforces the ZIR-XXX: Description format for all commit messages. Nightshift-Task: commit-normalize Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The scripts/commit-msg file is now tracked as executable (mode 100755) to eliminate the need for users to manually chmod the file during installation. Updated CONTRIBUTING.md to remove the chmod step from manual installation instructions. Nightshift-Task: commit-normalize Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the critical issue where the commit-msg hook was not tracked in the repository, preventing new contributors from installing it.
This PR supersedes #327 with the following fixes:
Changes
scripts/commit-msgcontaining the commit message validation hookscripts/install-commit-msg-hook.shto copy the hook fromscripts/commit-msgto.git/hooks/commit-msginstead of assuming it already existsCONTRIBUTING.mdto reference the correct source locationProblem Solved
Previously, the installation script assumed the commit-msg hook already existed in
.git/hooks/, which is not tracked by git. This meant:Now the hook is tracked in
scripts/commit-msgand can be installed by any contributor.Testing
The installation script has been tested and successfully:
scripts/commit-msgto.git/hooks/commit-msgThe hook correctly validates commit messages in the ZIR-XXX: Description format.
🤖 Generated with Claude Code