Open
Conversation
f024f35 to
1a8ac9d
Compare
Author
Updated: Iteration 2This PR has been updated with an improved Changes from Previous IterationConfiguration improvements:
Results:
Key ImprovementsThe previous iteration had issues where clang-format was expanding compact macro statements like: IF(isZeroBit) { eqz(val); }Into multi-line format: IF(isZeroBit) {
eqz(val);
}The new configuration preserves the compact style (with just a space added before parentheses): IF (isZeroBit) { eqz(val); }This maintains the project's coding style while applying consistent formatting across the codebase. |
Updated .clang-format to properly handle project-specific macros (IF, NONDET) by using ForEachMacros and enabling AllowShortBlocksOnASingleLine. This preserves the compact style for single-line statements within macros while maintaining consistent formatting across the codebase. Changes: - Updated .clang-format configuration: - Set AllowShortIfStatementsOnASingleLine: WithoutElse - Set AllowShortLoopsOnASingleLine: true - Set AllowShortBlocksOnASingleLine: Always - Added ForEachMacros for IF and NONDET - Formatted 241 C++ files (484 total files processed) - Net reduction of 2533 lines (1720 insertions, 4253 deletions) The new configuration keeps single-line control flow statements compact, improving code density and readability without sacrificing clarity. Nightshift-Task: lint-fix Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1a8ac9d to
5d08840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configuration Changes
Updated .clang-format with:
AllowShortIfStatementsOnASingleLine: WithoutElse- keeps compact single-line if statementsAllowShortLoopsOnASingleLine: true- allows single-line loopsAllowShortBlocksOnASingleLine: Always- preserves compact block statementsForEachMacrosfor IF and NONDET - treats these project macros like control flow statementsThe new configuration maintains the project's compact coding style for single-line control flow statements, improving code density and readability without sacrificing clarity.
Changes
Applied formatting fixes to 241 files across:
Testing
No functional changes - formatting only. All existing tests should continue to pass.
🤖 Generated with Claude Code