Add animation when overlayOpacity is zero#275
Open
ArthurInTheShell wants to merge 2 commits intorilyu:masterfrom
Open
Add animation when overlayOpacity is zero#275ArthurInTheShell wants to merge 2 commits intorilyu:masterfrom
ArthurInTheShell wants to merge 2 commits intorilyu:masterfrom
Conversation
Added a check for the overlayOpacity that is passed in and also Theme.overlayOpacity, whichever one is used. Use 'overlayOpacityStartedZero' in state to check if the overlayOpacity started as 0. Allow close animation to work without changing the opacity when it started as 0.
Author
|
This is my first pull request ever, please point out my mistake if this PR is bad. I will learn from my mistake! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check for the overlayOpacity that is passed in and also Theme.overlayOpacity, whichever one is used. Use 'overlayOpacityStartedZero' in state to check if the overlayOpacity started as 0. Allow close animation to work without changing the opacity when it started as 0.
related to issue #274 and #267