Skip to content

Include request_id in handshake error responses#839

Open
almstrand wants to merge 1 commit intorethinkdb:nextfrom
almstrand:fix/838
Open

Include request_id in handshake error responses#839
almstrand wants to merge 1 commit intorethinkdb:nextfrom
almstrand:fix/838

Conversation

@almstrand
Copy link
Copy Markdown

@almstrand almstrand commented Sep 25, 2016

Fixes #838

When an exception is thrown inside handshake (server/src/auth.js) it is currently caught in error_wrap_socket (server/src/client.js) where the originating request's request_id is unknown. Failed handshake requests will therefore respond with request_id: null

This change is to instead return a rejected promise, which will be caught in the catch clause inside handle_handshake (server/src/client.js), from where a JSON response is sent including the request_id.


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant