Angular2 chat app#609
Open
deadcee wants to merge 11 commits intorethinkdb:nextfrom
Open
Conversation
Contributor
Author
|
The offending commit has been removed. Thanks for pointing it out. |
Contributor
|
Awesome demo @deadcee! I'm going to say that we probably don't want to commit the Once I get back in the office let me spin it up and then we can get this merged 👍 |
Author
|
config.toml was removed and better user guidelines in README.md |
Contributor
|
@deadcee you do not need to run step 3 and in step 4 tsc. |
Contributor
|
Hey @deadcee would you mind taking a look at this again when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a similar pull request to the one summited by @zubair-io.
Includes some fixes to the index.html
This change is