Split domProps into separate subtypes #8162
Draft
+258
−243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building custom jsx transformers or defining bindings for "jsx-libraries" other than react, it could be possible, that some "fields" in domProps has other types as in the core library.
Examples:
So, if you want to add a field, fine. Just extend domProps.
But if you want to change an existing field, you have to create your own type and copy hundreds of existing fields. This is tedious.
I splitted the domProps into some subtypes, so it is easier to define your own domProps.
Example:
What do you think?
Is there an easier way?
Does it have performance implications?