fix(encoding): support sparse boolean lists in full-zip encoding#21
Merged
Merged
Conversation
Booleans encoded as 1-bit packed values cannot be interleaved byte-by-byte
in the full-zip layout, which caused a panic ("Non-byte aligned full-zip
compression not yet supported") when a list of booleans was sparse enough
to trigger the miniblock → full-zip fallback (introduced in lance-format#6234).
Fix: expand 1-bit boolean values to 1 byte each before full-zip encoding,
and re-pack bytes to Arrow's bit-packed format on decode.
Closes lance-format#6681
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andrea-reale
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of commit shenganzhang@978365f (as of creating this PR, not yet merged upstream)