Update endstops before reasoning about z probe#632
Update endstops before reasoning about z probe#632martinschulze wants to merge 1 commit intorepetier:developmentfrom
Conversation
|
After checking the code I see that it should not be necessary (which would also explain why I never needed it). See for example this part where you added it: the second true in moveRelativeDistanceInSteps tells to check and update endstop status in the move. So as long as move is long enough to have 2 steps without triggered endstop it must reset the z-probe (unless you have problems with cross talk). Could it be that your moves up are too short? |
|
In fact, the line you mention, that I got with the firmware from the configuration tool on 2017-01-03 looks |
|
Ok, might be that I switched to false for a short while and that of course would make your changes required. So bad timing in that case. |
Hey,
on my delta printer I have to update the endstops before reasoning about the z probe. Otherwise the error message "did not untrigger" is printed though the z probe definitely untriggered (it has a LED and manually checking z probe status returns untriggered as well).
I put it in twice in a row because I found it done this way some lines 547 and 548, but I don't know if it is necessary here.
Would be nice to find this in the official development branch so that I don't have to fix it manually before each update.
Martin